Ensure that addLinkAttributes is always called with a valid url parameter
#11134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameter There's no good reason for calling this helper function without a `url` parameter, and this way we can prevent that from happening. Note how the `PDFOutlineViewer` call-site was already doing the right thing here, and only the `LinkAnnotationElement` call-site needed a small adjustment to make it work.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/35ec0711b95a974/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/96c9dfc7971177b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/35ec0711b95a974/output.txt Total script time: 17.64 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/96c9dfc7971177b/output.txt Total script time: 25.75 mins
|
timvandermeij
approved these changes
Sep 11, 2019
|
Nice clean-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no good reason for calling this helper function without a
urlparameter, and this way we can prevent that from happening.Note how the
PDFOutlineViewercall-site was already doing the right thing here, and only theLinkAnnotationElementcall-site needed a small adjustment to make it work.Smaller diff with https://github.com/mozilla/pdf.js/pull/11134/files?w=1